ci: Display performance measurement results as custom metrics #3491
Conversation
Display performance measurement results as custom metrics
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3491 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 159 159
Lines 10145 10145
Branches 2863 2896 +33
=======================================
Hits 9303 9303
Misses 840 840
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
k2tzumi
force-pushed
the
octocov-custom-metrix
branch
from
6b36a6c
to
9d9c15a
Compare
|
If this PR is taken in, additional action may be needed. |
|
@EdamAme-x |
|
Thank you all, these are nice improvements! Type performance is the only thing I mildly warn about when recommending hono to everyone! I love seeing how hono and its ecosystem is improving every week and hoping to contribute back with our own OS projects. Keep up the great work. |
k2tzumi
force-pushed
the
octocov-custom-metrix
branch
from
9d9c15a
to
53bd319
Compare
There was a problem hiding this comment.
@yusukebe @EdamAme-x
Hi, I added the bundle size support. Can you take a look?
Octocov custom metrix
…69186026#step:7:96, Fix `no such file or directory`
|
Hi @EdamAme-x Also, can you review this? |
|
I was not able to verify the execution of jobs in |
There was a problem hiding this comment.
Great work!
(I had a Ureteral stone that knocked me down, so my review was late confirming it. My apologies lol.)
It would be a good idea to show both B and KB on custom metrics (but I don't think there's any rush to implement it now).
At any rate, let's try it out and see if there is any inconvenience in actually using it.
|
Thank you! Let's land it! |
|
Wooow, super cool! |
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the codeWhat's this all about?
This will be an improvement in type checking performance monitoring added by the following Pull Request.
#3406
In conjunction with octocov, type checking performance will be displayed as Pull Request comments and CI summary as follows
Pull Request comments
note: The bundle size is not shown as a diff since it is the first time, but it will be shown after the main branch is updated.Looks like the diff showed up just fine!
CI summary
